[jira] [Commented] (FLINK-17761) FutureCompletingBlockingQueue should have a capacity limit.

[liufangliang (Jira)]

    [ 
https://issues.apache.org/jira/browse/FLINK-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129243#comment-17129243
 ] 

liufangliang commented on FLINK-17761:
--------------------------------------

Hi [~becket_qin],

can i pack this issue ?

the current constructor of `FutureCompletingBlockingQueue` is like this
{code:java}
public FutureCompletingBlockingQueue(FutureNotifier futureNotifier) {
   this.futureNotifier = futureNotifier;
}
{code}
 

I am going to add a constructor taking capacity as a parameter,for example:
{code:java}
private final static Integer DEFAULT_CAPACITY = 10000;

public FutureCompletingBlockingQueue(FutureNotifier futureNotifier) {
   this(futureNotifier, DEFAULT_CAPACITY);
}

public FutureCompletingBlockingQueue(FutureNotifier futureNotifier, int 
capacity) {
   super(capacity);
   this.futureNotifier = futureNotifier;
}
{code}
What do you think about ？

 

> FutureCompletingBlockingQueue should have a capacity limit.
> -----------------------------------------------------------
>
>                 Key: FLINK-17761
>                 URL: https://issues.apache.org/jira/browse/FLINK-17761
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Connectors / Common
>            Reporter: Jiangjie Qin
>            Priority: Major
>
> Currently FutureCompletingBlockingQueue does not have a capacity. It should 
> have one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)