[GitHub] [flink] zjffdu commented on a change in pull request #12346: [FLINK-17944][sql-client] Wrong output in sql client's table mode

[GitBox]

zjffdu commented on a change in pull request #12346:
URL: https://github.com/apache/flink/pull/12346#discussion_r436532416



##########
File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectStreamResult.java
##########
@@ -224,7 +224,7 @@ private void processDelete(Row row) {
                }
 
                for (int i = startSearchPos; i >= validRowPosition; i--) {
-                       if (materializedTable.get(i).equals(row)) {
+                       if (materializedTable.get(i).fieldsEquals(row)) {
                                materializedTable.remove(i);
                                rowPositionCache.remove(row);

Review comment:
       @twalthr  Is it safe to do that ? I see many places use this field.
   
![image](https://user-images.githubusercontent.com/164491/84008773-e2060f00-a9a4-11ea-8f10-0b239a183d49.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org