zhijiangW opened a new pull request #12511:
URL: https://github.com/apache/flink/pull/12511
## What is the purpose of the change
There are three aborting scenarios which might encounter race condition:
1. CheckpointBarrierUnaligner#processCancellationBarrier
2. CheckpointBarrierUnaligner#processEndOfPartition
3. AlternatingCheckpointBarrierHandler#processBarrier
They only consider the pending checkpoint triggered by #processBarrier from
task thread to abort it. Actually the checkpoint might also be triggered by
#notifyBarrierReceived from netty thread in race condition, so we should also
handle properly to abort it.
## Brief change log
- Fix the process of AlternatingCheckpointBarrierHandler#processBarrier
- Fix the process of CheckpointBarrierUnaligner#processEndOfPartition to
abort checkpoint properly
- Fix the process of CheckpointBarrierUnaligner#processCancellationBarrier
to abort checkpoint properly
## Verifying this change
- Added new unit test
`CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterNotifyBarrierReceived`
- Added new unit test
`CheckpointBarrierUnalignerTest#testProcessCancellationBarrierAfterProcessBarrier`
- Added new unit test
`CheckpointBarrierUnalignerTest#testProcessCancellationBarrierBeforeProcessAndReceiveBarrier`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
