Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-176194702
Thanks for picking up this issue. This goes into a very good direction.
Few remaining points:
- There are a lot of unrelated reformattings. The general rule is not to
reformat comments or indentation for anything not touched in the pull request.
Otherwise all people keep just formatting back and forth each others changes,
because everyone believes they personally figured out the better code style ;-)
Would be good to undo the changes in the `FileSystem` class, for example.
- Some tests would be great. With refactorings of YARN going on, I can
see that this change will be accidentally undone next time something with a
main() method is touched, unless a test guards this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
