[
https://issues.apache.org/jira/browse/FLINK-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121495#comment-15121495
]
ASF GitHub Bot commented on FLINK-2380:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-176194702
Thanks for picking up this issue. This goes into a very good direction.
Few remaining points:
- There are a lot of unrelated reformattings. The general rule is not to
reformat comments or indentation for anything not touched in the pull request.
Otherwise all people keep just formatting back and forth each others changes,
because everyone believes they personally figured out the better code style ;-)
Would be good to undo the changes in the `FileSystem` class, for example.
- Some tests would be great. With refactorings of YARN going on, I can
see that this change will be accidentally undone next time something with a
main() method is touched, unless a test guards this.
> Allow to configure default FS for file inputs
> ---------------------------------------------
>
> Key: FLINK-2380
> URL: https://issues.apache.org/jira/browse/FLINK-2380
> Project: Flink
> Issue Type: Improvement
> Components: JobManager
> Affects Versions: 0.9, 0.10.0
> Reporter: Ufuk Celebi
> Assignee: Kostas
> Priority: Minor
> Labels: starter
> Fix For: 1.0.0
>
>
> File inputs use "file://" as default prefix. A user asked to make this
> configurable, e.g. "hdfs://" as default.
> (I'm not sure whether this is already possible or not. I will check and
> either close or implement this for the user.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
