zhijiangW commented on a change in pull request #12460:
URL: https://github.com/apache/flink/pull/12460#discussion_r434676298
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/CheckpointBarrierUnaligner.java
##########
@@ -117,17 +117,6 @@
threadSafeUnaligner = new ThreadSafeUnaligner(totalNumChannels,
checkNotNull(channelStateWriter), this);
}
- @Override
- public void releaseBlocksAndResetBarriers() {
- if (isCheckpointPending()) {
- // make sure no additional data is persisted
- Arrays.fill(hasInflightBuffers, false);
- // the next barrier that comes must assume it is the
first
- numBarrierConsumed = 0;
- }
-
threadSafeUnaligner.resetReceivedBarriers(currentConsumedCheckpointId);
- }
-
Review comment:
I also found the issues caused by `AlternatingCheckpointBarrierHandler`
via the failed unit tests. I will consider how to refactor it to make
`AlternatingCheckpointBarrierHandler` go through.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
