Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1536#issuecomment-174953115
I don't really see the points of encapsulating parts of the examples into
methods: Usually, methods are used when functionality is used in different
places. In this case, every method is only called once (there is no generic
abstraction). Its adding an unnecessary level of indirection, making it harder
to read the code.
I don't see why reading the initial dataset is less important than the rest
of the application.
Reading the file is just 5 lines of code (relevant code, I woudn't call
that boilerplate).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
