dianfu edited a comment on pull request #12370: URL: https://github.com/apache/flink/pull/12370#issuecomment-636424283
@xintongsong @zhuzhurk Thanks for the review. Have updated the PR. The main changes are as following: - DO NOT set the value of "taskmanager.memory.task.off-heap.size" automatically - If Python UDF and RocksDB are used together and both Python UDF and RocksDB are configured to use managed memory, throw exceptions with meaningful suggestions. - If Python UDF is configured to use off-heap memory and the task off-heap memory could not meet the requirement, throw exceptions with meaningful suggestions. Please note that the default value of "python.fn-execution.memory.managed" is still false which means that Python UDF will not use managed memory by default. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org