DashShen opened a new pull request #12369:
URL: https://github.com/apache/flink/pull/12369
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/browse/FLINK-17678). Exceptions are made
for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-17678] [Connectors/HBase]
Title of the pull request", where *FLINK-17678* should be replaced by the
actual issue number. Skip *component* if you are unsure about which is the best
component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Azure Pipelines CI to do that following [this
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Flink doesn't contains a hbase shade jar right now, so users have to add
hbase dependency manually. This pull request is trying to solve this problem.
Add a new flink-sql-connector-hbase modular likes
flink-sql-connector-elasticsearch7.
## Brief change log
- Add new modular flink-sql-connector-hbase.
- Add new hbase end to end test.
## Verifying this change
This new modular flink-sql-connector-hbase only includes necessary
dependencies that used to reading or writing data from/to hbase.
**NOTE**:
1. We do not shade hadoop dependencies into the jar. Becasuse
flink-sql-connector-hive doesn't contains either, so we do this in similar way.
2. We shade all dependencies that hbase needed but except
`org.apache.hadoop.hbase.codec.*` for preventing hbase client throw timeout
exception . Because the hbase server can not find the shaded codec class to
decoding data(byte[]).
3. We add a new end to end test of hbase. To execute this e2e test, the test
script will download hbase.tar.gz and flink-shade-hadoop-uber jar. In this test
script, we test correctness by using sql-client.sh
4. To avoid class not found exception, we replace the hbase-default.xml
which excludes theses configuration such like:
```xml
<property>
<name>hbase.status.listener.class</name>
<value>org.apache.hadoop.hbase.client.ClusterStatusListener$MulticastListener</value>
<description>
Implementation of the status listener with a multicast message.
</description>
</property>
```
Because if we don't remove this property, hbase client will try to load the
class that configured in hbase-default.xml. But actually , all these classes
have already been shaded and can't be loaded by those default canonical name.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
