senegalo commented on pull request #12056: URL: https://github.com/apache/flink/pull/12056#issuecomment-634251720
Thanks a lot for the time and effort guys. Will review your suggestions on Friday and do the required changes :) On Tue 26. May 2020 at 17:24, Austin Cawley-Edwards < notificati...@github.com> wrote: > I like the idea of passing the correlationId in with each collected > record - I think it makes more sense from a users point of view than the > setCorrelationId semantics, and the allowing multiple uses of a > correlationId in a single pass sounds like something that should be > hidden from the user anyway. @senegalo <https://github.com/senegalo>, > what do you think? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/flink/pull/12056#issuecomment-634094634>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAVGRIYB2DGYPP3QA7PCWZLRTPNJXANCNFSM4M4YTD2A> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
