wuchong commented on a change in pull request #12284:
URL: https://github.com/apache/flink/pull/12284#discussion_r429996195
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -633,8 +648,11 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
sinkFunction = new
KeyedUpsertingSinkFunction(
tableName,
converter,
- keyIndices);
+ keyIndices,
+ expectedNum);
} else {
+ checkArgument(expectedNum == -1,
+ "Retracting Sink doesn't
support '" + SINK_EXPECTED_MESSAGES_NUM.key() + "' yet.");
Review comment:
I think there is not much difference. It's more easier to check the
`expectedNum` in the `getSinkRuntimeProvider`, because we have to check
`runtimeSink` and `primaryKey`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
