zentol commented on a change in pull request #12264:
URL: https://github.com/apache/flink/pull/12264#discussion_r429896972
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -490,6 +490,13 @@
+ " size will be used. The exact size of JVM
Overhead can be explicitly specified by setting the min/max"
+ " size to the same value.");
+ @Documentation.ExcludeFromDocumentation("This option just serves as a
last-ditch escape hatch.")
+ public static final ConfigOption<Integer> NUM_IO_THREADS =
+ key("taskmanager.io.threads.num")
+ .intType()
+ .defaultValue(2)
+ .withDescription("The number of threads to use for
non-critical IO operations.");
Review comment:
hmm...maybe; the use-cases are quite different though?
`CLUSTER_IO_EXECUTOR_POOL_SIZE` is currently used for the pool we use for
the HA executor pool, which is probably pretty important stuff.
Meanwhile, on the TM it is mostly about disk cleanup.
Should these really be controlled through the same option? If a user sees a
problem with slow disk cleanup and increases the pool size, should this really
affect the HA side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
