rkhachatryan commented on a change in pull request #8693:
URL: https://github.com/apache/flink/pull/8693#discussion_r427152958



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -328,6 +421,7 @@ private OperatorSnapshotFutures 
buildOperatorSnapshotFutures(
 
        @Override
        public void close() throws IOException {
+               asyncCheckpointRunnables.close();

Review comment:
       `try/catch` (or guava Closer or some other way to close both closeables 
no matter what?)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to