[ 
https://issues.apache.org/jira/browse/FLINK-15793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110994#comment-17110994
 ] 

Yang Wang commented on FLINK-15793:
-----------------------------------

Currently, the native K8s integration does not using the existing script(e.g. 
{{jobmanager.sh}}, {{taskmanager.sh}}) to start JobManager and TaskManager. 
Instead, the java start command is generate by Flink internally(i.e. 
{{KubernetesClusterDescriptor}}, {{KubernetesResourceManager}}).

[~chesnay] So is it possible to add the following codes to 
{{docker-entrypoint.sh}} in apache/flink-docker[1]? The primary purpose is to 
export some environment that could be use to run the JobManager/TaskManager 
java command. Benefit from this change we could make the 
{{docker-entrypoint.sh}} as default command for native K8s deployment. Then the 
{{kubernetes-entry.sh}} could be removed directly.

 
{code:java}
. "$bin"/config.sh

FLINK_CLASSPATH=`manglePathList 
$(constructFlinkClassPath):$INTERNAL_HADOOP_CLASSPATHS`
export FLINK_CLASSPATH

echo "Start command : $*"

exec "$@"
{code}
 

[1]. 
[https://github.com/apache/flink-docker/blob/dev-master/docker-entrypoint.sh#L125]

> Move kubernetes-entry.sh out of FLINK_HOME/bin
> ----------------------------------------------
>
>                 Key: FLINK-15793
>                 URL: https://issues.apache.org/jira/browse/FLINK-15793
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Deployment / Kubernetes
>    Affects Versions: 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.11.0, 1.10.2
>
>
> Currently, {{FLINK_HOME/bin}} contains the file {{kubernetes-entry.sh}}. This 
> file is used to customize Flink's default Docker image. I think 
> {{FLINK_HOME/bin}} should not contain files which cannot be directly used. 
> Either we move them to another directory or we incorporate it into Flink's 
> default Docker image. If we opt for the latter option, then this task is 
> related to FLINK-12546.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to