[
https://issues.apache.org/jira/browse/FLINK-17793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110918#comment-17110918
]
Timo Walther edited comment on FLINK-17793 at 5/19/20, 7:32 AM:
----------------------------------------------------------------
Computed columns, watermarks, primary key are not needed in `TableSchema` in
the API. Also utility functions like `toPhysicalRowDataType` and
`toRowDataType`. All of this is just catalog related. For the API, it can be an
interface backed by LogicalType (not DataType anymore because we drop legacy in
1.12). I think this topic is too complex to have it in 1.11 but I will work on
a little design document for discussion. We can create a FLIP out of it, if
needed.
was (Author: twalthr):
Computed columns, watermarks, primary key are not needed in `TableSchema` in
the API. Also utility functions like `toPhysicalRowDataType` and
`toRowDataType`. All of this is just catalog related. Also utility functions
like `toRowType` . For the API, it can be an interface backed by LogicalType
(not DataType anymore because we drop legacy in 1.12). I think this topic is
too complex to have it in 1.11 but I will work on a little design document for
discussion. We can create a FLIP out of it, if needed.
> Replace TableSchema with dedicated CatalogSchema
> ------------------------------------------------
>
> Key: FLINK-17793
> URL: https://issues.apache.org/jira/browse/FLINK-17793
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
>
> The {{TableSchema}} is used for representing the schema of catalog table and
> the schema of a {{Table}} object and operation. We should split those
> responsibilities both for a cleaner API and long-term separation of concerns.
> Connectors should work on a CatalogSchema instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
