aljoscha commented on a change in pull request #12147:
URL: https://github.com/apache/flink/pull/12147#discussion_r425658414
##########
File path:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
##########
@@ -202,11 +193,10 @@ protected AbstractFetcher(
}
// if we have periodic watermarks, kick off the interval
scheduler
- if (timestampWatermarkMode == PERIODIC_WATERMARKS) {
- @SuppressWarnings("unchecked")
- PeriodicWatermarkEmitter periodicEmitter = new
PeriodicWatermarkEmitter(
+ if (timestampWatermarkMode == WITH_WATERMARK_GENERATOR) {
+ PeriodicWatermarkEmitter<KPH> periodicEmitter = new
PeriodicWatermarkEmitter<>(
Review comment:
Yes, I'm doing the second suggestions. 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
