Myasuka commented on a change in pull request #8693:
URL: https://github.com/apache/flink/pull/8693#discussion_r425549498
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -464,6 +464,11 @@ public void notifyCheckpointComplete(long
completedCheckpointId) throws Exceptio
}
}
+ @Override
+ public void notifyCheckpointAborted(long checkpointId) {
+ // nothing to do
+ }
+
Review comment:
I prefer the idea to not leave default implementation of
`notifyCheckpointAborted`, thus leave it here could be acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
