[GitHub] [flink] KurtYoung commented on a change in pull request #12069: [FLINK-14807][streaming] Add specialized collecting sink function

[GitBox]

KurtYoung commented on a change in pull request #12069:
URL: https://github.com/apache/flink/pull/12069#discussion_r424882491



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java
##########
@@ -162,9 +174,28 @@ public RetryingRegistrationConfiguration 
getRetryingRegistrationConfiguration()
        //  Static factory methods
        // 
--------------------------------------------------------------------------------------------
 
+       @VisibleForTesting
        public static TaskManagerConfiguration fromConfiguration(
                        Configuration configuration,
                        TaskExecutorResourceSpec taskExecutorResourceSpec) {
+               try {
+                       TaskManagerServicesConfiguration servicesConfiguration =
+                               
TaskManagerServicesConfiguration.fromConfiguration(
+                                       configuration,
+                                       ResourceID.generate(),
+                                       
InetAddress.getLoopbackAddress().getHostAddress(),

Review comment:
       You only need an address that you can successfully connect to, no matter 
this address is the same with TMs or not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org