[ 
https://issues.apache.org/jira/browse/FLINK-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105341#comment-17105341
 ] 

Timo Walther edited comment on FLINK-17631 at 5/12/20, 11:39 AM:
-----------------------------------------------------------------

Modifying ConfigOption is a pretty tricky business. We spend so much work in 
convincing people to add the current data types.

Instead we need a validation layer that checks min/max string legnth in my 
opinion.

We had already a full design for this:
https://cwiki.apache.org/confluence/display/FLINK/FLIP-54%3A+Evolve+ConfigOption+and+Configuration#FLIP-54:EvolveConfigOptionandConfiguration-OptionValidation

The FLIP was too big to reach consensus. So we decided to just go with the data 
types first and add the validation later. If we want to fully replace 
DescriptorProperties we need those in my opinion.


was (Author: twalthr):
Modifying ConfigOption is a pretty tricky business. We spend so much work in 
convincing people to add the current data types. I will look into it but I’m 
not sure about adding more types.

Instead we need a validation layer that checks min/max string legnth in my 
opinion.

We had already a full design for this:
https://cwiki.apache.org/confluence/display/FLINK/FLIP-54%3A+Evolve+ConfigOption+and+Configuration#FLIP-54:EvolveConfigOptionandConfiguration-OptionValidation

The FLIP was too big to reach consensus. So we decided to just go with the data 
types first and add the validation later. If we want to fully replace 
DescriptorProperties we need those in my opinion.

> Supports char type for ConfigOption
> -----------------------------------
>
>                 Key: FLINK-17631
>                 URL: https://issues.apache.org/jira/browse/FLINK-17631
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Core
>    Affects Versions: 1.11.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>             Fix For: 1.11.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to