[GitHub] [flink] twalthr commented on a change in pull request #11989: [FLINK-16804] Deprecate all Table methods that accept expressions as a String

[GitBox]

twalthr commented on a change in pull request #11989:
URL: https://github.com/apache/flink/pull/11989#discussion_r420585523



##########
File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/GroupWindowedTable.java
##########
@@ -63,7 +63,7 @@
         *
         * <pre>
         * {code

Review comment:
       `@code` is missing

##########
File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/GroupedTable.java
##########
@@ -47,11 +47,19 @@
         * Performs a selection operation on a grouped table. Similar to an SQL 
SELECT statement.
         * The field expressions can contain complex expressions and 
aggregations.
         *
+        * <p>Example:
+        *
+        * <pre>
+        * {@code
+        *   tab.groupBy($("key")).select($("key"), $("value").avg(), lit("The 
average").as("average"));

Review comment:
       use plus here as well

##########
File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/GroupedTable.java
##########
@@ -47,11 +47,19 @@
         * Performs a selection operation on a grouped table. Similar to an SQL 
SELECT statement.
         * The field expressions can contain complex expressions and 
aggregations.
         *
+        * <p>Example:
+        *
+        * <pre>
+        * {@code
+        *   tab.groupBy($("key")).select($("key"), $("value").avg(), lit("The 
average").as("average"));
+        * }
+        * </pre>
+        *
         * <p>Scala Example:
         *
         * <pre>
         * {@code
-        *   tab.groupBy('key).select('key, 'value.avg + " The average" as 
'average)
+        *   tab.groupBy($"key").select($"key", $"value".avg, "The average" as 
"average")

Review comment:
       missing plus




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org