zhijiangW commented on a change in pull request #11687:
URL: https://github.com/apache/flink/pull/11687#discussion_r419513791



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -168,6 +175,12 @@ public void run() {
        Optional<BufferAndAvailability> getNextBuffer() throws IOException, 
InterruptedException {
                checkError();
 
+               BufferAndAvailability bufferAndAvailability = 
getNextRecoveredStateBuffer();
+               if (bufferAndAvailability != null) {

Review comment:
       My previous assumption was that the local channel will not be chosen by 
`SingleInputGate` to read if there were no buffers to insert into 
`RecoveredInputChannel#receivedBuffers` to notify 
`SingleInputGate.notifyChannelNonEmpty` before.
   Or I missed some other corner case?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to