[
https://issues.apache.org/jira/browse/FLINK-16478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098931#comment-17098931
]
Till Rohrmann edited comment on FLINK-16478 at 5/4/20, 1:37 PM:
----------------------------------------------------------------
Hi [~dixingx...@yeah.net], thanks for drafting the design. I have a couple of
comments.
1. I would suggest to narrow the scope of the feature for the MVP a bit.
Instead of supporting all kinds of namespaces, different components (single TM,
all TMs, all components), timer for log level, etc., I would suggest to start
with the bare minimum. In my opinion it would be controlling the cluster wide
log level.
2. The part which is missing from the design document but which is crucial in
my opinion is which logging backends we want to support. This includes what
happens in the cluster is started with an unsupported logging backend or with
an incompatible version. This answer
https://stackoverflow.com/questions/23434252/programmatically-change-log-level-in-log4j2
indicates that log4j2 has different means to configure the log level depending
on the log4j2 version. Moreover, I would be interested how configuring the
actual logging backend would look like.
3. Do we know whether other systems support this kind of feature? If yes, how
do they solve it for different logging backends?
was (Author: till.rohrmann):
Hi [~dixingx...@yeah.net], thanks for drafting the design. I have a couple of
comments.
1. I would suggest to narrow the scope of the feature for the MVP a bit.
Instead of supporting all kinds of namespaces, different components (single TM,
all TMs, all components), timer for log level, etc., I would suggest to start
with the bare minimum. In my opinion it would be controlling the cluster wide
log level.
2. The part which is missing from the design document but which is crucial in
my opinion is which logging backends we want to support. This includes what
happens in the cluster is started with an unsupported logging backend or with
an incompatible version. This answer
https://stackoverflow.com/questions/23434252/programmatically-change-log-level-in-log4j2
indicates that log4j2 has different means to configure the log level depending
on the log4j2 version. Moreover, I would be interested how configuring the
actual logging backend would look like.
> add restApi to modify loglevel
> -------------------------------
>
> Key: FLINK-16478
> URL: https://issues.apache.org/jira/browse/FLINK-16478
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / REST
> Reporter: xiaodao
> Priority: Minor
>
> sometimes we may need to change loglevel to get more information to resolved
> bug, now we need to stop it and modify conf/log4j.properties and resubmit it
> ,i think it's better to add rest api to modify loglevel.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
