edu05 commented on a change in pull request #11952:
URL: https://github.com/apache/flink/pull/11952#discussion_r418310356
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTestingUtils.java
##########
@@ -357,8 +359,11 @@ static ExecutionJobVertex mockExecutionJobVertex(
when(executionJobVertex.getParallelism()).thenReturn(parallelism);
when(executionJobVertex.getMaxParallelism()).thenReturn(maxParallelism);
when(executionJobVertex.isMaxParallelismConfigured()).thenReturn(true);
-
when(executionJobVertex.getOperatorIDs()).thenReturn(jobVertexIDs);
-
when(executionJobVertex.getUserDefinedOperatorIDs()).thenReturn(Arrays.asList(new
OperatorID[jobVertexIDs.size()]));
+ List<OperatorIdPair> operatorIdPairs = new ArrayList<>();
+ for (OperatorID operatorID : jobVertexIDs) {
+ operatorIdPairs.add(new OperatorIdPair(operatorID,
null));
Review comment:
done, is it a terrible idea that both factory methods have the same name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
