sjwiesman commented on a change in pull request #11878:
URL: https://github.com/apache/flink/pull/11878#discussion_r418065687



##########
File path: docs/dev/table/python/common_questions.md
##########
@@ -22,12 +22,19 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-This page describes the solutions to some frequently encountered problems for 
PyFlink users.
+This page describes the solutions to some common questions for PyFlink users.
 
 * This will be replaced by the TOC
 {:toc}
 ## Preparing Python Virtual Environment
-You can download a [convenience 
script](https://github.com/apache/flink/blob/master/flink-python/dev/setup-pyflink-virtual-env.sh)
 to prepare a Python virtual env zip which can be used on Mac OS and most Linux 
distributions. 
+You can download a [convenience script](setup-pyflink-virtual-env.sh) to 
prepare a Python virtual env zip which can be used on Mac OS and most Linux 
distributions.
+
+You can specify the version parameter to generate a Python virtual environment 
required for the corresponding PyFlink version. e.g.
+
+{% highlight shell %}
+# you will get a Python virtual environment required by PyFlink version 1.10
+setup-pyflink-virtual-env.sh 1.10

Review comment:
       How about this: 
   
   {% if site.is_stable %}
   $ setup-pyflink-virtual-env.sh {{ site.version }}
   {% else %}
   $ setup-pyflink-virtual-env.sh
   {% endif %}
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to