rkhachatryan commented on pull request #8693: URL: https://github.com/apache/flink/pull/8693#issuecomment-621386224
Thanks for the contribution, @Myasuka . Can you please rebase your changes to the latest master? As we moved most checkpointing-related functionality recently from `StreamTask` to `SubtaskCheckpointCoordinator`, I think task changes should go there. I have some high-level remarks: 1. does it make sense to split the commit (or even PR) into several pieces addressing JM and TM separately? 2. can you add a component name to the commit message? 3. `AsyncCheckpointRunnable.cancelled` seems not to be used. And why not to add a new AsyncCheckpointState instead (or reuse `DISCARDED`)? 4. I don't see how `AsyncCheckpointRunnable` is canceled or its thread is stopped; which is the original goal of this PR I believe ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
