pnowojski commented on a change in pull request #11567:
URL: https://github.com/apache/flink/pull/11567#discussion_r415797164



##########
File path: 
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java
##########
@@ -174,6 +173,20 @@
                                " help relieve back-pressure caused by 
unbalanced data distribution among the subpartitions. This value should be" +
                                " increased in case of higher round trip times 
between nodes and/or larger number of machines in the cluster.");
 
+       /**
+        * Number of max buffers can be used for each output subparition.
+        */
+       @Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER_NETWORK)
+       public static final ConfigOption<Integer> 
NETWORK_MAX_BUFFERS_PER_CHANNEL =
+                       key("taskmanager.network.max-buffers-per-channel")
+                                       .defaultValue(Integer.MAX_VALUE)

Review comment:
       Also I would set this to `10`. What do you think @zhijiangW ?
   
   10 = 2 exclusive + 8 floating - so that single channel could use all of them 
up, but if someone increases floating buffers, we have a sensible limit?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to