fpompermaier opened a new pull request #11914:
URL: https://github.com/apache/flink/pull/11914


   ## What is the purpose of the change
   
   Fix error when handling numeric field types with precision 0, such as:
   
   ```sql
   CREATE TABLE orders(
       ord_no integer PRIMARY KEY,
       ord_date date,
       item_name character(35),
       item_grade character(1),
       ord_qty numeric,
       ord_amount numeric,
       CONSTRAINT unq_ordno_itname UNIQUE(ord_qty,ord_amount)
   );
   ```
   
   This address the same problem of SPARK-26538 
(https://github.com/apache/spark/pull/23456), using the same fix.
   
   ## Brief change log
   
   In the PostgresCatalog.fromJDBCType, handle Decimal and Numeric types as 
follow:
   
   ```java
   if (precision > 0) {
        return DataTypes.DECIMAL(precision, metadata.getScale(colIndex));
   }
   return DataTypes.DECIMAL(DecimalType.MAX_PRECISION, 18);
   ```
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
*PostgresCatalogITCase*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`:  **no**
     - The serializers:  **no**
     - The runtime per-record code paths (performance sensitive):  **no**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper:  **no**
     - The S3 file system connector:  **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  **no**
     - If yes, how is the feature documented? not documented
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to