docete commented on a change in pull request #11837: URL: https://github.com/apache/flink/pull/11837#discussion_r414342841
########## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/utils/testTableSourceSinks.scala ########## @@ -200,6 +199,65 @@ class TestTableSourceWithTime[T]( } } +class TestTableSourceWithTimeFactory[T] extends StreamTableSourceFactory[T] { + override def createStreamTableSource(properties: JMap[String, String]): StreamTableSource[T] = { + val dp = new DescriptorProperties() + dp.putProperties(properties) + + val isBounded = dp.getOptionalBoolean("is-bounded").orElse(false) + val tableSchema = dp.getTableSchema(Schema.SCHEMA) + val serializedData = dp.getOptionalString("data").orElse(null) + val data = if (serializedData != null) { + EncodingUtils.decodeStringToObject(serializedData, classOf[List[T]]) + } else { + Seq.empty[T] + } + val rowtimeAttributes = SchemaValidator.deriveRowtimeAttributes(dp) + val rowtime = if (rowtimeAttributes.isEmpty) { + null + } else { + rowtimeAttributes.head.getAttributeName + } + val proctimeAttribute = SchemaValidator.deriveProctimeAttribute(dp) + val proctime = if (proctimeAttribute.isPresent) { + proctimeAttribute.get() + } else { + null + } + + val serializedMapKeys = dp.getOptionalString("map-keys").orElse(null) + val serializedMapVals = dp.getOptionalString("map-vals").orElse(null) + val mapping = if (serializedMapKeys != null && serializedMapVals != null) { + val mapKeys = EncodingUtils.decodeStringToObject(serializedMapKeys, classOf[List[String]]) + val mapVals = EncodingUtils.decodeStringToObject(serializedMapVals, classOf[List[String]]) + if (mapKeys.length != mapVals.length) { + null + } else { + mapKeys.zip(mapVals).toMap + } + } else { + null + } + + val existingTs = dp.getOptionalString("existingTs").orElse(null) + + new TestTableSourceWithTime[T]( + isBounded, tableSchema, null, data, rowtime, proctime, mapping, existingTs) Review comment: See TableScanITCase#testProctimeTableSource() It should use this factory after we remove tableEnv.registerTableSource() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org