zentol commented on a change in pull request #11879:
URL: https://github.com/apache/flink/pull/11879#discussion_r414334764
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/metrics/JobVertexWatermarksHandlerTest.java
##########
@@ -87,7 +87,7 @@ public void before() throws Exception {
Time.seconds(1),
Collections.emptyMap(),
metricFetcher,
- Mockito.mock(ExecutionGraphCache.class),
+ Mockito.mock(DefaultExecutionGraphCache.class),
Review comment:
can we use the noop cache instead?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/AbstractExecutionGraphHandler.java
##########
@@ -95,7 +96,7 @@ protected AbstractExecutionGraphHandler(
/**
* Called for each request after the corresponding {@link
AccessExecutionGraph} has been retrieved from the
- * {@link ExecutionGraphCache}.
+ * {@link DefaultExecutionGraphCache}.
Review comment:
should be reverted
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
##########
@@ -725,13 +731,28 @@ public WebMonitorEndpoint(
@Override
public void startInternal() throws Exception {
leaderElectionService.start(this);
+ startExecutionGraphCacheCleanupTask();
+
if (hasWebUI) {
log.info("Web frontend listening at {}.",
getRestBaseUrl());
}
}
+ private void startExecutionGraphCacheCleanupTask() {
+ final long cleanupInterval = 2 *
restConfiguration.getRefreshInterval();
Review comment:
Why did you choose this as the cleanup interval? Why not "just" the
refresh interval?
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
##########
@@ -59,7 +59,7 @@
import static org.junit.Assert.fail;
/**
- * Tests for the {@link ExecutionGraphCache}.
+ * Tests for the {@link DefaultExecutionGraphCache}.
*/
public class ExecutionGraphCacheTest extends TestLogger {
Review comment:
rename to `DefaultExecutionGraphCacheTest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
