KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r414312301
##########
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/runtime/SavepointEnvironment.java
##########
@@ -198,6 +199,11 @@ public GlobalAggregateManager getGlobalAggregateManager() {
throw new UnsupportedOperationException(ERROR_MSG);
}
+ @Override
+ public Map<String, ExternalResourceDriver> getExternalResourceDrivers()
{
+ return Collections.emptyMap();
+ }
Review comment:
I did throw an exception but I found error in `SavepointWriterITCase `.
It seems currently the
`SavepointEnvironment` would still be used to construct a
`StreamingRuntimeContext`. I'm not familiar with savepoint mechanism. But I
guess it is an issue because the constructor of `SavepointEnvironment` already
took a `RuntimeContext` instance. It does not make sense to construct
`RuntimeContext` from it again. Thus, I currently choose to return `emptyMap`
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
