lamber-ken commented on issue #10228:
URL: https://github.com/apache/flink/pull/10228#issuecomment-618370265


   > Hi @lamber-ken
   > could the thread dump be part of the log list?
   > cc @jinglining
   
   hi @vthinkxie, thread dump is not a real file, we shouldn't place it on log 
list
   ```
   // TaskExecutor#requestLogList
   @Override
   public CompletableFuture<Collection<LogInfo>> requestLogList(Time timeout) {
        return CompletableFuture.supplyAsync(() -> {
                final String logDir = 
taskManagerConfiguration.getTaskManagerLogDir();
                if (logDir != null) {
                        final File[] logFiles = new File(logDir).listFiles();
   
                        if (logFiles == null) {
                                throw new CompletionException(new 
FlinkException(String.format("There isn't a log file in TaskExecutor’s log dir 
%s.", logDir)));
                        }
   
                        return Arrays.stream(logFiles)
                                        .filter(File::isFile)
                                        .map(logFile -> new 
LogInfo(logFile.getName(), logFile.length()))
                                        .collect(Collectors.toList());
                }
                return Collections.emptyList();
        }, ioExecutor);
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to