twalthr commented on a change in pull request #11568:
URL: https://github.com/apache/flink/pull/11568#discussion_r412833841
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/table/validation/TableSinkValidationTest.scala
##########
@@ -91,8 +91,8 @@ class TableSinkValidationTest extends TableTestBase {
expectedException.expectMessage(
"Field types of query result and registered TableSink default_catalog." +
"default_database.testSink do not match.\n" +
- "Query schema: [a: INT, b: BIGINT, c: STRING, d: BIGINT]\n" +
- "Sink schema: [a: INT, b: BIGINT, c: STRING, d: INT]")
+ "Query schema: [a: INT, b: BIGINT, c: VARCHAR(2147483647), d: BIGINT]\n"
+
+ "Sink schema: [a: INT, b: BIGINT, c: VARCHAR(2147483647), d: INT]")
Review comment:
This is an exception. So we should print the full details to the user,
such that the user can compare character by character. If we don't like
`VARCHAR(2147483647)` I'm fine with changing the serializable representation of
this logical type to `STRING`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
