[ https://issues.apache.org/jira/browse/FLINK-17273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089254#comment-17089254 ]
Canbin Zheng edited comment on FLINK-17273 at 4/22/20, 3:25 AM: ---------------------------------------------------------------- Thanks for your attention! [~xintongsong] [~trohrmann] [~fly_in_gis] Given the following call stack, {quote}{{ResourceManager#releaseResource}} - {{KubernetesResourceManager#stopWorker}} - {{KubernetesResourceManager#internalStopPod}} - {{ResourceManager#closeTaskManagerConnection}} {quote} I think it's enough to explicitly call {{ResourceManager#closeTaskManagerConnection}} in {{KubernetesResourceManager#removePodIfTerminated}} for this issue. was (Author: felixzheng): Thanks for your attention! [~xintongsong] [~fly_in_gis] Given the following call stack, {quote}{{ResourceManager#releaseResource}} - {{KubernetesResourceManager#stopWorker}} - {{KubernetesResourceManager#internalStopPod}} - {{ResourceManager#closeTaskManagerConnection}} {quote} I think it's enough to explicitly call {{ResourceManager#closeTaskManagerConnection}} in {{KubernetesResourceManager#removePodIfTerminated}} for this issue. > Fix not calling ResourceManager#closeTaskManagerConnection in > KubernetesResourceManager in case of registered TaskExecutor failure > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: FLINK-17273 > URL: https://issues.apache.org/jira/browse/FLINK-17273 > Project: Flink > Issue Type: Bug > Components: Deployment / Kubernetes, Runtime / Coordination > Affects Versions: 1.10.0, 1.10.1 > Reporter: Canbin Zheng > Assignee: Canbin Zheng > Priority: Major > Fix For: 1.11.0 > > > At the moment, the {{KubernetesResourceManager}} does not call the method of > {{ResourceManager#closeTaskManagerConnection}} once it detects that a > currently registered task executor has failed. This ticket propoeses to fix > this problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)