KarmaGYZ commented on a change in pull request #11615:
URL: https://github.com/apache/flink/pull/11615#discussion_r412612905
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/StandaloneResourceManagerFactory.java
##########
@@ -74,4 +81,21 @@
standaloneClusterStartupPeriodTime,
AkkaUtils.getTimeoutAsTime(configuration));
}
+
+ /**
+ * Get the configuration for standalone ResourceManager, overwrite
invalid configs.
+ *
+ * @param configuration configuration object
+ * @return the configuration for standalone ResourceManager
+ */
+ private static Configuration
getConfigurationForStandaloneResourceManager(Configuration configuration) {
+ final Configuration copiedConfig = new
Configuration(configuration);
+ if
(configuration.contains(ResourceManagerOptions.MAX_SLOT_NUM)) {
+ // The max slot limit should not take effect for
standalone cluster, we overwrite the configure in case user
+ // sets this value by mistake.
+ LOG.warn("The {} should not take effect for standalone
cluster, If configured, it will be ignored.",
ResourceManagerOptions.MAX_SLOT_NUM.key());
+
copiedConfig.removeConfig(ResourceManagerOptions.MAX_SLOT_NUM);
Review comment:
I think the `if(contains())` might be a bit readable than
`if(removeConfig)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
