tillrohrmann commented on a change in pull request #11473:
URL: https://github.com/apache/flink/pull/11473#discussion_r412281489



##########
File path: 
flink-core/src/main/java/org/apache/flink/core/execution/PipelineExecutor.java
##########
@@ -41,5 +41,5 @@
         * @param configuration the {@link Configuration} with the required 
execution parameters
         * @return a {@link CompletableFuture} with the {@link JobClient} 
corresponding to the pipeline.
         */
-       CompletableFuture<JobClient> execute(final Pipeline pipeline, final 
Configuration configuration) throws Exception;
+       CompletableFuture<? extends JobClient> execute(final Pipeline pipeline, 
final Configuration configuration) throws Exception;

Review comment:
       I think this change is not necessary and can be reverted. No explicit 
cast should be required if simply using an `thenApply(Function.identity())` 
with the right generics.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to