GJL commented on a change in pull request #11770: URL: https://github.com/apache/flink/pull/11770#discussion_r411148799
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategyTest.java ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.io.network.partition.ResultPartitionType; +import org.apache.flink.runtime.scheduler.ExecutionVertexDeploymentOption; +import org.apache.flink.util.TestLogger; + +import org.junit.Before; +import org.junit.Test; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +import static org.hamcrest.Matchers.hasSize; +import static org.hamcrest.Matchers.lessThanOrEqualTo; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertThat; + +/** + * Unit tests for {@link PipelinedRegionSchedulingStrategy}. + */ +public class PipelinedRegionSchedulingStrategyTest extends TestLogger { + + private TestingSchedulerOperations testingSchedulerOperation; + + private int parallelism = 2; Review comment: Consider making this static final or convert to a local variable. ########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/TestingSchedulingPipelinedRegion.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; + +/** + * A simple implementation of {@link SchedulingPipelinedRegion} for testing. + */ +public class TestingSchedulingPipelinedRegion implements SchedulingPipelinedRegion { + + private final Map<ExecutionVertexID, TestingSchedulingExecutionVertex> regionVertices = new HashMap<>(); + + private final Set<TestingSchedulingResultPartition> consumedPartitions = new HashSet<>(); + + public TestingSchedulingPipelinedRegion(final Set<TestingSchedulingExecutionVertex> vertices) { + for (TestingSchedulingExecutionVertex vertex : vertices) { + regionVertices.put(vertex.getId(), vertex); + + for (TestingSchedulingResultPartition consumedPartition : vertex.getConsumedResults()) { + if (!vertices.contains(consumedPartition.getProducer())) { + consumedPartitions.add(consumedPartition); + } + } + } + } + + @Override + public Iterable<TestingSchedulingExecutionVertex> getVertices() { + return regionVertices.values(); Review comment: Consider wrapping it in `Collections.unmodifiableCollection()` for immutability or returning a copy. Same in `getConsumedResults()`. ########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/TestingSchedulingTopology.java ########## @@ -78,6 +83,31 @@ public TestingSchedulingResultPartition getResultPartition(final IntermediateRes return resultPartition; } + @Override + public Iterable<SchedulingPipelinedRegion> getAllPipelinedRegions() { + return vertexRegions.values().stream().collect(Collectors.toSet()); + } + + @Override + public SchedulingPipelinedRegion getPipelinedRegionOfVertex(ExecutionVertexID vertexId) { + return vertexRegions.get(vertexId); + } + + void generatePipelinedRegions() { Review comment: Consider invoking this method lazily in `getAllPipelinedRegions()` and `getPipelinedRegionOfVertex()` instead of relying the client (test) to invoke it. ########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/TestingSchedulingTopology.java ########## @@ -78,6 +83,31 @@ public TestingSchedulingResultPartition getResultPartition(final IntermediateRes return resultPartition; } + @Override + public Iterable<SchedulingPipelinedRegion> getAllPipelinedRegions() { + return vertexRegions.values().stream().collect(Collectors.toSet()); Review comment: I think that's the same as `new HashSet<>(vertexRegions.values())` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
