KurtYoung commented on a change in pull request #11397:
URL: https://github.com/apache/flink/pull/11397#discussion_r411156938
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -196,8 +196,12 @@ public void open() {
if (line == null) {
continue;
}
- final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
- cmdCall.ifPresent(this::callCommand);
+ try {
+ final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
+ cmdCall.ifPresent(this::callCommand);
+ } catch (Throwable t) {
Review comment:
> The process might be in a bad state then
This makes sense, there is a risk that we will do more damage if don't
exist.
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -196,8 +196,12 @@ public void open() {
if (line == null) {
continue;
}
- final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
- cmdCall.ifPresent(this::callCommand);
+ try {
+ final Optional<SqlCommandCall> cmdCall =
parseCommand(line);
+ cmdCall.ifPresent(this::callCommand);
+ } catch (Throwable t) {
Review comment:
> The process might be in a bad state then
This makes sense, there is a risk that we will do more damage if don't exit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
