libenchao commented on a change in pull request #11797:
[FLINK-17169][table-blink] Refactor BaseRow to use RowKind instead of byte
header
URL: https://github.com/apache/flink/pull/11797#discussion_r410906083
##########
File path: flink-core/src/main/java/org/apache/flink/types/RowKind.java
##########
@@ -52,5 +52,26 @@
/**
* Deletion operation.
*/
- DELETE
+ DELETE;
+
+ /**
+ * Returns a short string representation of this {@link RowKind}.
+ *
+ * <ul>
+ * <li>"I" represents {@link #INSERT}.</li>
+ * <li>"UB" represents {@link #UPDATE_BEFORE}.</li>
+ * <li>"UA" represents {@link #UPDATE_AFTER}.</li>
+ * <li>"D" represents {@link #DELETE}.</li>
+ * </ul>
+ */
+ public String shortString() {
Review comment:
What if we add a parameter for each enum, for example, INSERT("I"),
UPDATE_BEFORE("UB"). Then we don't need this switch-case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
