zhijiangW commented on a change in pull request #11687:
[FLINK-16536][network][checkpointing] Implement InputChannel state recovery for
unaligned checkpoint
URL: https://github.com/apache/flink/pull/11687#discussion_r410380283
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -213,19 +215,23 @@ public SingleInputGate(
}
@Override
- public void setup() throws IOException, InterruptedException {
+ public void setup() throws IOException {
Review comment:
Yes, I guess so.
I found another benefit to execute the input state recovery inside
`StreamTask` instead of `Task` stack(setup integration). The new dedicated
executor for unspilling channel state is only meaningful for the unaligned
checkpoint mode. So I tried not to create this executor for normal checkpoints,
also for batch jobs to reduce total threads in TaskManager. This improvement
can only be done inside `StreamTask` because it can judge the checkpoint mode
via `StreamConfig`. And task class can not get this option because of `runtime`
module can not depend on `streaming` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
