zhijiangW commented on a change in pull request #11786: [FLINK-17208][network]
Reduce redundant data available notifications of PipelinedSubpartition
URL: https://github.com/apache/flink/pull/11786#discussion_r410355533
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -434,15 +445,12 @@ public int getBuffersInBacklog() {
}
}
- private boolean shouldNotifyDataAvailable() {
- // Notify only when we added first finished buffer.
- return readView != null && !flushRequested &&
getNumberOfFinishedBuffers() == 1;
+ private boolean mayNotifyDataAvailable() {
+ return readView != null && !dataAvailableNotified;
}
private void notifyDataAvailable() {
Review comment:
we can remove this method completely, because calling this method has no
difference with calling `readView.notifyDataAvailable()` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
