[
https://issues.apache.org/jira/browse/FLINK-17023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085885#comment-17085885
]
Chesnay Schepler edited comment on FLINK-17023 at 4/17/20, 3:50 PM:
--------------------------------------------------------------------
The current behavior was fine; the method was used in an unexpected way which
lead to misleading error messages.
master: 0c9ced4e8175bf458060400c5f5a067f307fcd2a
was (Author: zentol):
master: 0c9ced4e8175bf458060400c5f5a067f307fcd2a
> Improve handling of unexpected input in config.sh#extractExecutionParams
> ------------------------------------------------------------------------
>
> Key: FLINK-17023
> URL: https://issues.apache.org/jira/browse/FLINK-17023
> Project: Flink
> Issue Type: Improvement
> Components: Deployment / Scripts
> Affects Versions: 1.11.0
> Reporter: Caizhi Weng
> Assignee: Caizhi Weng
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.11.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In FLINK-15727 {{BashJavaUtils}} now returns multiple lines of results to
> avoid using {{BashJavaUtils}} twice. But now the format checking in
> {{extractExecutionParams}} for the last line is incorrect. Instead of
> {code:bash}
> if ! [[ $execution_config =~ ^${EXECUTION_PREFIX}.* ]]; then
> echo "[ERROR] Unexpected result: $execution_config" 1>&2
> echo "[ERROR] The last line of the BashJavaUtils outputs is expected to
> be the execution result, following the prefix '${EXECUTION_PREFIX}'" 1>&2
> echo "$output" 1>&2
> exit 1
> fi
> {code}
> It should be
> {code:bash}
> last_line=`echo "$execution_config" | tail -n 1`
> if ! [[ "$last_line" =~ ^${EXECUTION_PREFIX}.* ]]; then
> # ...
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
