zhuzhurk commented on a change in pull request #11783: [FLINK-17181][runtime] Drop generic Types in SchedulingTopology Interface URL: https://github.com/apache/flink/pull/11783#discussion_r410026090
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/PipelinedRegionComputeUtil.java ########## @@ -45,7 +45,7 @@ private static final Logger LOG = LoggerFactory.getLogger(PipelinedRegionComputeUtil.class); public static Set<PipelinedRegion> toPipelinedRegionsSet( - final Set<? extends Set<? extends SchedulingExecutionVertex>> distinctRegions) { + final Set<? extends Set<SchedulingExecutionVertex>> distinctRegions) { Review comment: It can be further simplified to Set<Set<SchedulingExecutionVertex>>. The return type of below method `toExecutionVertexIdSet()` can be simplified as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services