dianfu commented on a change in pull request #11784: [FLINK-17120][python] Add
Cython support for operations
URL: https://github.com/apache/flink/pull/11784#discussion_r409991523
##########
File path: flink-python/pyflink/fn_execution/coders.py
##########
@@ -177,6 +187,9 @@ def __init__(self, elem_coder):
def _create_impl(self):
return coder_impl.ArrayCoderImpl(self._elem_coder.get_impl())
+ def get_impl(self):
Review comment:
If get_impl is already defined in the base class, it is not necessary to
define it in child class again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
