zhuzhurk commented on a change in pull request #11770: [FLINK-17014][runtime] Implement PipelinedRegionSchedulingStrategy URL: https://github.com/apache/flink/pull/11770#discussion_r409983049
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategyTest.java ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.scheduler.strategy; + +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.io.network.partition.ResultPartitionType; +import org.apache.flink.runtime.scheduler.ExecutionVertexDeploymentOption; +import org.apache.flink.util.TestLogger; + +import org.junit.Before; +import org.junit.Test; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; +import java.util.stream.Stream; + +import static org.hamcrest.Matchers.is; +import static org.hamcrest.Matchers.lessThanOrEqualTo; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertThat; + +/** + * Unit tests for {@link PipelinedRegionSchedulingStrategy}. + */ +public class PipelinedRegionSchedulingStrategyTest extends TestLogger { + + private TestingSchedulerOperations testingSchedulerOperation; + + private int parallelism = 2; + + private TestingSchedulingTopology testingSchedulingTopology; + + private List<TestingSchedulingExecutionVertex> source; + + private List<TestingSchedulingExecutionVertex> map; + + private List<TestingSchedulingExecutionVertex> sink; + + @Before + public void setUp() { + testingSchedulerOperation = new TestingSchedulerOperations(); + + buildTopology(); + } + + private void buildTopology() { + testingSchedulingTopology = new TestingSchedulingTopology(); + + source = testingSchedulingTopology.addExecutionVertices().withParallelism(parallelism).finish(); + map = testingSchedulingTopology.addExecutionVertices().withParallelism(parallelism).finish(); + sink = testingSchedulingTopology.addExecutionVertices().withParallelism(parallelism).finish(); + + testingSchedulingTopology.connectPointwise(source, map) + .withResultPartitionState(ResultPartitionState.CREATED) + .withResultPartitionType(ResultPartitionType.PIPELINED_BOUNDED) + .finish(); + testingSchedulingTopology.connectAllToAll(map, sink) + .withResultPartitionState(ResultPartitionState.CREATED) + .withResultPartitionType(ResultPartitionType.BLOCKING) + .finish(); + + testingSchedulingTopology.generatePipelinedRegions(); + } + + @Test + public void testStartScheduling() { + startScheduling(testingSchedulingTopology); + + final List<List<TestingSchedulingExecutionVertex>> expectedScheduledVertices = new ArrayList<>(); + expectedScheduledVertices.add(Arrays.asList(source.get(0), map.get(0))); + expectedScheduledVertices.add(Arrays.asList(source.get(1), map.get(1))); + assertLatestScheduledVerticesAreEqualTo(expectedScheduledVertices); + } + + @Test + public void testRestartTasks() { + final PipelinedRegionSchedulingStrategy schedulingStrategy = startScheduling(testingSchedulingTopology); + + final Set<ExecutionVertexID> verticesToRestart = Stream.of(source, map, sink) + .flatMap(List::stream) + .map(TestingSchedulingExecutionVertex::getId) + .collect(Collectors.toSet()); + + schedulingStrategy.restartTasks(verticesToRestart); + + final List<List<TestingSchedulingExecutionVertex>> expectedScheduledVertices = new ArrayList<>(); + expectedScheduledVertices.add(Arrays.asList(source.get(0), map.get(0))); + expectedScheduledVertices.add(Arrays.asList(source.get(1), map.get(1))); + assertLatestScheduledVerticesAreEqualTo(expectedScheduledVertices); + } + + @Test + public void testNotifyingBlockingResultPartitionProducerFinished() { + final PipelinedRegionSchedulingStrategy schedulingStrategy = startScheduling(testingSchedulingTopology); + + final TestingSchedulingExecutionVertex map1 = map.get(0); + map1.getProducedResults().iterator().next().setState(ResultPartitionState.CONSUMABLE); + schedulingStrategy.onExecutionStateChange(map1.getId(), ExecutionState.FINISHED); + + // sinks' inputs are not all consumable yet so they are not scheduled + assertThat(testingSchedulerOperation.getScheduledVertices().size(), is(2)); Review comment: Ok. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
