GJL commented on a change in pull request #11683: [FLINK-15347] Add SupervisorActor which monitors the proper termination of AkkaRpcActors URL: https://github.com/apache/flink/pull/11683#discussion_r408668235
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/ActorSystemResource.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rpc.akka; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.runtime.akka.AkkaUtils; +import org.apache.flink.util.Preconditions; + +import akka.actor.ActorSystem; +import org.junit.rules.ExternalResource; + +/** + * External resource which starts an {@link akka.actor.ActorSystem}. + */ +public class ActorSystemResource extends ExternalResource { + + private final Configuration configuration; + + private ActorSystem actorSystem; + + private ActorSystemResource(Configuration configuration) { + this.configuration = configuration; + } + + @Override + protected void before() throws Throwable { + super.before(); + + Preconditions.checkState(actorSystem == null, "ActorSystem must not be initialized when calling before."); + actorSystem = AkkaUtils.createLocalActorSystem(configuration); + } + + @Override + protected void after() { + Preconditions.checkState(actorSystem != null, "ActorSystem must be initialized when calling after."); + AkkaUtils.terminateActorSystem(actorSystem).join(); + + super.after(); Review comment: Not needed to call `super.before()` and `super.after()`. Also not done in their own code (e.g., `TemporaryFolder`) and in the examples in Junit's Javadocs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
