tillrohrmann commented on a change in pull request #11363:
[FLINK-16440][runtime] Extend SlotManager metrics and status for dynamic slot
allocation.
URL: https://github.com/apache/flink/pull/11363#discussion_r409672644
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerFactory.java
##########
@@ -47,10 +48,12 @@
FatalErrorHandler fatalErrorHandler,
ClusterInformation clusterInformation,
@Nullable String webInterfaceUrl,
- ResourceManagerMetricGroup resourceManagerMetricGroup)
throws Exception {
+ MetricRegistry metricRegistry,
+ String hostname) throws Exception {
final ResourceManagerRuntimeServices
resourceManagerRuntimeServices = createResourceManagerRuntimeServices(
- configuration, rpcService, highAvailabilityServices);
+ configuration, rpcService, highAvailabilityServices,
metricRegistry, hostname);
Review comment:
I think we could pass in the `SlotManagerMetricGroup` at this point. This
would have the benefit that we would not have to forward the `metricRegistry`
and the `hostname` all the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
