dianfu commented on a change in pull request #11749: [FLINK-16669][python][table] Support Python UDF in SQL function DDL. URL: https://github.com/apache/flink/pull/11749#discussion_r409263779
########## File path: flink-python/src/main/java/org/apache/flink/client/python/PythonFunctionFactory.java ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.python; + +import org.apache.flink.api.java.ExecutionEnvironment; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.ReadableConfig; +import org.apache.flink.table.functions.python.PythonFunction; + +import java.io.IOException; +import java.util.concurrent.ExecutionException; + +/** + * The factory which creates the PythonFunction objects from given module name and object name. + */ +public interface PythonFunctionFactory { + + /** + * Returns PythonFunction according to moduleName and objectName. The current environment is also + * needed because different environments have different code generation logic. + * + * @param moduleName The module name of the Python UDF. + * @param objectName The function name / class name of the Python UDF. + * @return The PythonFunction object which represents the Python UDF. + */ + PythonFunction getPythonFunction(String moduleName, String objectName); + + /** + * Returns PythonFunction according to the fully qualified name of the Python UDF + * i.e ${moduleName}.${functionName} or ${moduleName}.${className}. The current environment is also + * needed because different environments have different code generation logic. + * + * @param fullyQualifiedName The fully qualified name of the Python UDF. + * @param config The configuration of python dependencies. + * @return The PythonFunction object which represents the Python UDF. + */ + static PythonFunction getPythonFunction(String fullyQualifiedName, ReadableConfig config) + throws IOException, ExecutionException, InterruptedException { + int splitIndex = fullyQualifiedName.lastIndexOf("."); + String moduleName = fullyQualifiedName.substring(0, splitIndex); Review comment: What happens if there is no `.` in the fullyQualifiedName? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
