twalthr commented on a change in pull request #11694:
[FLINK-17064][table-planner] Improve literals conversion in ExpressionConverter
URL: https://github.com/apache/flink/pull/11694#discussion_r408866120
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java
##########
@@ -76,6 +85,9 @@ public boolean isNull() {
/**
* Returns the value (excluding null) as an instance of the given class.
*
+ * <p>It supports conversions to default conversion classes of {@link
LogicalType LogicalTypes}.
+ * This method should not be called with other classes.
Review comment:
nit: should we mention big decimal as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
