dianfu commented on a change in pull request #11718: [FLINK-17118][python] Support Primitive DataTypes in Cython URL: https://github.com/apache/flink/pull/11718#discussion_r408782758
########## File path: flink-python/pyflink/fn_execution/tests/test_coders_common.py ########## @@ -36,65 +36,230 @@ def check_coder(self, coder, *values): else: self.assertEqual(v, coder.decode(coder.encode(v))) + def check_cython_coder(self, python_field_coders, cython_field_coders, data): Review comment: Rename test_coders_common to test_coders.py and Move the coders for cython to test_fast_coders.py? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services