wsry commented on a change in pull request #11351: [FLINK-16404][runtime] Avoid
caching buffers for blocked input channels before barrier alignment
URL: https://github.com/apache/flink/pull/11351#discussion_r408568257
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -883,16 +883,7 @@ private void configureCheckpointing() {
CheckpointingMode mode = cfg.getCheckpointingMode();
- boolean isExactlyOnce;
- if (mode == CheckpointingMode.EXACTLY_ONCE) {
- isExactlyOnce = true;
- } else if (mode == CheckpointingMode.AT_LEAST_ONCE) {
- isExactlyOnce = false;
- } else {
- throw new IllegalStateException("Unexpected
checkpointing mode. " +
- "Did not expect there to be another
checkpointing mode besides " +
- "exactly-once or at-least-once.");
- }
+ boolean isExactlyOnce = cfg.isCheckpointingEnabled() && mode ==
CheckpointingMode.EXACTLY_ONCE;
Review comment:
I move this to another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
